-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSN-34] - Create navbar and footer #40
Conversation
@rogacky11 why there is a link to RSN-14?
|
I apologize for my mistake, link changed. I also forgot about ready for review status, so it has been immediately added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also - better idea would be to put the links - Reasn, logowanie, rejestracja inside another div like below:
Instead of making some weird margins mx-60 you can specify it's with in % (3/4 would be 75% as in design).
One more thing - you didn't format it properly from what I see, so it will be needed to use some sort of prettier or something for that.
Also, you can name it not Nav.tsx but something more meaningful like Navbar or Menu or something like that and place it in 'components' folder. Also - making separate components for Links like logowanie and rejestracja could be a good idea, since it will be reusable then and we (for logged user) want to display more than that, so it shouldnt be hardcoded. + if Link type is not used, it should be deleted (also styles import).
And the last thing - where is the footer?
Do it via youtrack, just drag the issue in in review state and it will assign the status automatically here |
Instead of making some weird margins mx-60 you can specify it's with in % (3/4 would be 75% as in design). One more thing - you didn't format it properly from what I see, so it will be needed to use some sort of prettier or something for that. Also, you can name it not Nav.tsx but something more meaningful like Navbar or Menu or something like that and place it in 'components' folder. Also - making separate components for Links like logowanie and rejestracja could be a good idea, since it will be reusable then and we (for logged user) want to display more than that, so it shouldnt be hardcoded. + if Link type is not used, it should be deleted (also styles import).
I took your advices into account and added adequately. |
@rogacky11 if it's ready for review mark it as ready for review, currently it's a draft PR |
@rogacky11 please resolve conflicts / rebase + format code |
Created #47 |
Description
I have added visual changes to our web application using tailwind css.
Motivation
This change is needed to create navbar and footer.
Related issue and/or ticket
RSN-34