Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RSN-31] - Create validators according to constraints #32

Merged
merged 27 commits into from
Jun 6, 2024
Merged

[RSN-31] - Create validators according to constraints #32

merged 27 commits into from
Jun 6, 2024

Conversation

mkoper02
Copy link
Collaborator

@mkoper02 mkoper02 commented May 11, 2024 •
edited by raczu
Loading

Description

Create validators which will validate entities on backend side before putting them into database.

Related issue and/or ticket

RSN-31

@mkoper02 mkoper02 added scope: backend Indicates that PR relates to backend changes. type: feature PR's categorised as feature. labels May 11, 2024
@mkoper02 mkoper02 self-assigned this May 11, 2024
@mkoper02 mkoper02 marked this pull request as ready for review May 14, 2024 08:42
@mkoper02 mkoper02 added the status: ready for review Determines that PR is ready for review. label May 14, 2024
@mkoper02 mkoper02 requested a review from wzarek May 14, 2024 08:42
wzarek
wzarek requested changes May 15, 2024
View reviewed changes
Copy link
Owner

@wzarek wzarek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex strings and hardcoded numbers can be put as a seperate const value in class itself (will be cleaner that way and easier to do changes).

@wzarek wzarek added status: require changes Determines that PR requires changes to be approved. and removed status: ready for review Determines that PR is ready for review. labels May 15, 2024
@mkoper02 mkoper02 added status: ready for review Determines that PR is ready for review. and removed status: require changes Determines that PR requires changes to be approved. labels May 15, 2024
@mkoper02 mkoper02 requested a review from wzarek May 15, 2024 16:24
@mkoper02 mkoper02 removed the status: ready for review Determines that PR is ready for review. label May 20, 2024
@mkoper02 mkoper02 marked this pull request as draft May 20, 2024 23:25
@wzarek wzarek added the status: require changes Determines that PR requires changes to be approved. label May 20, 2024
@mkoper02 mkoper02 removed the status: require changes Determines that PR requires changes to be approved. label May 20, 2024
@wzarek wzarek mentioned this pull request Jun 3, 2024
Merged
@wzarek wzarek assigned raczu and unassigned mkoper02 Jun 3, 2024
raczu added 5 commits June 4, 2024 17:13
@raczu
feat: add jwt and exceptions handlers
30a8666 
Simplify the logic on the controllers' side, custom exceptions and
a library for validation were added. The implemented handlers are
allow to catch those exceptions and return the corresponding
statuses and detailed response.

Additionally, mappers have been created to more easily convert
entities into the corresponding DTOs, fixed enum conversion
when it comes to UserRole and export postgres port on the
development environment.
@raczu
test: add unit tests for jwt, handlers and validators
14e3333
@raczu
style: format code with dotnet format
26348f0
@raczu
Merge remote-tracking branch 'origin/RSN-40' into RSN-31
c6ad6fe
@raczu
refactor: rewrite validators to use fluent validation
fe7e7be
@raczu raczu marked this pull request as ready for review June 5, 2024 00:29
@wzarek wzarek added the status: ready for review Determines that PR is ready for review. label Jun 5, 2024
wzarek
wzarek approved these changes Jun 5, 2024
View reviewed changes
Copy link
Owner

@wzarek wzarek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raczu - please fix conflicts / rebase
Also check comment, other than that lgtm (decide if worth doing, if so - commit and merge, if not - just merge)

Server/ReasnAPI/ReasnAPI/Controllers/AuthController.cs Show resolved Hide resolved
@raczu raczu merged commit d1ca7f0 into main Jun 6, 2024
7 checks passed
@wzarek wzarek deleted the RSN-31 branch June 6, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raczu raczu raczu left review comments

@wzarek wzarek wzarek approved these changes

Assignees

@raczu raczu

Labels
scope: backend Indicates that PR relates to backend changes. status: ready for review Determines that PR is ready for review. type: feature PR's categorised as feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoper02 @raczu @wzarek