Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSN-45] - Change parameters architecture, replaced role, status, object type with enum #31

Merged
merged 9 commits into from
May 11, 2024

Conversation

mkoper02
Copy link
Collaborator

@mkoper02 mkoper02 commented May 9, 2024

Description

Changed Status, Role, Object_Type into enum in db, created new enum Type and added it to parameters table

Related issue and/or ticket

RSN-44

@mkoper02 mkoper02 added scope: database Indicates that PR relates to database changes. type: cleanup/refactor PR's categorised as cleanup or refactor. labels May 9, 2024
* Changed primary key setvalue to 10

* Update init-dev-data.sql

* Added setval to init-db
@mkoper02 mkoper02 self-assigned this May 9, 2024
Database/init-constraints.sql Outdated Show resolved Hide resolved
Database/init-constraints.sql Outdated Show resolved Hide resolved
Database/init-db.sql Outdated Show resolved Hide resolved
Added status constraints for event and participant tables.
Deleted 'is_predefined' in parameter table.
Changed init data.
@mkoper02 mkoper02 marked this pull request as ready for review May 10, 2024 08:19
@mkoper02 mkoper02 added the status: ready for review Determines that PR is ready for review. label May 10, 2024
Database/init-db.sql Outdated Show resolved Hide resolved
Database/init-dev-data.sql Outdated Show resolved Hide resolved
Database/init-dev-data.sql Outdated Show resolved Hide resolved
@wzarek wzarek added status: require changes Determines that PR requires changes to be approved. and removed status: ready for review Determines that PR is ready for review. labels May 10, 2024
@wzarek wzarek added status: ready for review Determines that PR is ready for review. and removed status: require changes Determines that PR requires changes to be approved. labels May 10, 2024
@wzarek wzarek self-requested a review May 10, 2024 15:26
Copy link
Owner

@wzarek wzarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@wzarek wzarek requested a review from raczu May 10, 2024 15:27
@wzarek
Copy link
Owner

wzarek commented May 10, 2024

@mkoper02 remember to rebase and review conflicts

Database/init-db.sql Outdated Show resolved Hide resolved
@wzarek wzarek self-requested a review May 10, 2024 17:19
Copy link
Collaborator

@raczu raczu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkoper02 mkoper02 merged commit 29e69e0 into main May 11, 2024
7 checks passed
@wzarek wzarek deleted the RSN-45 branch May 13, 2024 12:35
rogacky11 pushed a commit that referenced this pull request May 17, 2024
…ect type with enum (#31)

* Changed role, status and object_type tables into enum

* Update init-dev-data.sql

* Added status constraints for event and participant tables.
rogacky11 pushed a commit that referenced this pull request May 17, 2024
…ect type with enum (#31)

* Changed role, status and object_type tables into enum

* Update init-dev-data.sql

* Added status constraints for event and participant tables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: database Indicates that PR relates to database changes. status: ready for review Determines that PR is ready for review. type: cleanup/refactor PR's categorised as cleanup or refactor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants