-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSN-45] - Change parameters architecture, replaced role, status, object type with enum #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoper02
added
scope: database
Indicates that PR relates to database changes.
type: cleanup/refactor
PR's categorised as cleanup or refactor.
labels
May 9, 2024
* Changed primary key setvalue to 10 * Update init-dev-data.sql * Added setval to init-db
wzarek
requested changes
May 9, 2024
Added status constraints for event and participant tables. Deleted 'is_predefined' in parameter table. Changed init data.
mkoper02
added
the
status: ready for review
Determines that PR is ready for review.
label
May 10, 2024
wzarek
requested changes
May 10, 2024
wzarek
added
status: require changes
Determines that PR requires changes to be approved.
and removed
status: ready for review
Determines that PR is ready for review.
labels
May 10, 2024
wzarek
added
status: ready for review
Determines that PR is ready for review.
and removed
status: require changes
Determines that PR requires changes to be approved.
labels
May 10, 2024
wzarek
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@mkoper02 remember to rebase and review conflicts |
Added status constraints for event and participant tables. Deleted 'is_predefined' in parameter table. Changed init data.
wzarek
requested changes
May 10, 2024
wzarek
approved these changes
May 10, 2024
raczu
approved these changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
rogacky11
pushed a commit
that referenced
this pull request
May 17, 2024
…ect type with enum (#31) * Changed role, status and object_type tables into enum * Update init-dev-data.sql * Added status constraints for event and participant tables.
rogacky11
pushed a commit
that referenced
this pull request
May 17, 2024
…ect type with enum (#31) * Changed role, status and object_type tables into enum * Update init-dev-data.sql * Added status constraints for event and participant tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope: database
Indicates that PR relates to database changes.
status: ready for review
Determines that PR is ready for review.
type: cleanup/refactor
PR's categorised as cleanup or refactor.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed Status, Role, Object_Type into enum in db, created new enum Type and added it to parameters table
Related issue and/or ticket
RSN-44