[RSN-9] - Implemented DTO models on frontend #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzarek
added
status: ready for review
raczu
reviewed
May 3, 2024
raczu
requested changes
May 3, 2024
There was a problem hiding this comment.
After a long research and consideration of all possibilites, I think that the best solution will be to use zod - it does not depend on other libraries and is lightweight. This will greatly simplify the verification of data received from the API. Additionally, we will be able to use this library also to verify the data provided by the user (data from forms).
See below example, which shows an easy way to handle date conversion to proper object:
wzarek
added
status: require changes
…ng with unit tests
wzarek
added
status: ready for review
…ng with unit tests
raczu
requested changes
May 11, 2024
wzarek
added
status: require changes
wzarek
added
status: ready for review
raczu
approved these changes
May 19, 2024
wzarek
added
status: require changes
|
@raczu if everything is done please merge, checked partially and looks fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented models from DTO on backend to frontend with mappers from JSON string and object with unit tests.
Related issue and/or ticket
RSN-9