Added length limits and constraint for max length #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzarek
added
the
status: ready for review
wzarek
requested changes
Apr 14, 2024
There was a problem hiding this comment.
All seems fine, but if we use keywords in uppercase, then 'constraint' should be uppercase too. Another thing is - should .sql files be LF or CRLF? Because you have changed line endings to LF, so please do little research about it and if it should be LF - we would need to make similar changes to #5 so all SQL files would be standarized then.
wzarek
added
status: require changes
|
Add eol to LF to .gitattributes for all files except .cs |
wzarek
added
status: ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added max length constrains for all text variables in tables
Related issue and/or ticket
RSN-22