-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSN-39 Improve development environment #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: renamed docker compose files to compose*.yml. Simplify running up development environment. Now it requires to use simple command: docker-compose watch Introduce a watch mechanism in development environemnt to rebuild dotnet container each time the server source code is changed. Add healtcheck mechanism to ensure the functionality of the postgres before running up the rest of services.
BREAKING CHANGE: All previous services, tests etc. needs to be reapplied.
The change was made to simplify client development.
Mobile contenerization requires to specify your computer IP address to make it possible to use expo go.
Added Jest Added services from RSN-12 Split .gitignore
raczu
added
scope: ci/cd
Indicates that PR relates to workflows changes.
type: feature
PR's categorised as feature.
labels
Apr 8, 2024
wzarek
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope: ci/cd
Indicates that PR relates to workflows changes.
status: ready for review
Determines that PR is ready for review.
type: feature
PR's categorised as feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intorduces many changes, including chaning the current way of developing application and completely new client files structures to simplify its development. The names of current files used by
docker-compose
command was renamed tocompose.yml
andcompose.override.yml
. The second filecompose.override.yml
overwrites and add some specific configuration to prepare development environment, while the first one will mainly involve setting up production environment (which has not yet been fully prepared).It was decided to use
watch
andsync
mechanism, so that the changes in the source code of the application are also reflected in the containers, e.g. change to the server code will cause the image to be re-built and the server container to be restarted to reflect the change.Command to run up environment with
watch
mechanism:Command to run up environment without
watch
mechanism:Command to shut down environment:
Motivation
The motivation was to simplify development enviornment in order to run up all containers in one command and ensure their properly functioning, e.g. backend container depends on database container etc.
Related issue and/or ticket
#7 RSN-39