Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CPP for no longer supported GHC <9.0 #70

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Feb 12, 2024

The package no longer builds with GHCs older than 9.0.

When you try cabal build with ghc 8.10.7, you get this error:

Failed to build hie-compat-0.3.1.2.
Build log (
/home/jhrcek/.cabal/logs/ghc-8.10.7/hie-compat-0.3.1.2-6cd25c57f80a4565be3fe6faa473ae59b8a96c9dd34aa406aef36d991f3ccd54.log
):
Configuring library for hie-compat-0.3.1.2..
Preprocessing library for hie-compat-0.3.1.2..
Error: cabal-3.10.2.1: can't find source for Compat/HieAst in .,
dist/build/autogen, dist/build/global-autogen

Error: cabal: Failed to build hie-compat-0.3.1.2 (which is required by
test:hiedb-tests from hiedb-0.6.0.0). See the build log above for details.

Support for ghc 8.10 and older was removed from hie-compat in haskell/haskell-language-server#3434

So I'd say that we can safely remove CPP related to older GHCs from this repo too AND mention it in the changelog.

@jhrcek jhrcek requested a review from wz1000 February 12, 2024 05:10
@@ -24,8 +24,10 @@
* Handle duplicate record fields in GHC 9.8 instead of crashing

## 0.4.4.0 -- 2023-11-13

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first release following drop of support from hie compat several months before this was released, so adding it here retrospectively.

@wz1000 wz1000 merged commit cf132f1 into wz1000:master Feb 15, 2024
5 checks passed
@jhrcek jhrcek deleted the jhrcek/remove-cpp-pre-ghc-9.0 branch February 22, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants