Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ghc-9.0.1 #31

Merged
merged 7 commits into from
Jun 26, 2021
Merged

Add support for ghc-9.0.1 #31

merged 7 commits into from
Jun 26, 2021

Conversation

anka-213
Copy link
Contributor

@anka-213 anka-213 commented Mar 29, 2021

I have not yet now made it backwards compatible.

To make dependencies work with ghc-9.0.1, you also need the fixes to hie-compat from haskell/haskell-language-server#1635 (and probably updates to some other packages as well, I haven't checked which).

(Progress towards haskell/haskell-language-server#297)

@anka-213
Copy link
Contributor Author

anka-213 commented Mar 29, 2021

We can probably make it backwards-compatible by conditionally defining

type Unit = UnitId
moduleUnit = moduleUnitId

and a few similar things somewhere.

@anka-213 anka-213 marked this pull request as ready for review March 29, 2021 18:43
@anka-213
Copy link
Contributor Author

Oh, right, the CI doesn't use the included cabal.project but instead generates its own. That's why it's failing on ghc-9.0.1.

@wz1000 wz1000 merged commit 9077035 into wz1000:master Jun 26, 2021
wz1000 pushed a commit that referenced this pull request Jun 26, 2021
* Add non-backwards compatible support for ghc-9.0.1

* Make changes backwards-compatible

* Fix warnings and tests

* Restore accidentally deleted project file

* Link the versions needed to build on ghc-9.0.1 in cabal.project

* Add ghc-9.0.1 to github actions

* Regenerate haskell-ci from cabal.project
@wz1000
Copy link
Owner

wz1000 commented Jun 26, 2021

Thanks! Finally got around to merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants