Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warnings for implicit external names #9

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Remove warnings for implicit external names #9

merged 1 commit into from
Feb 20, 2020

Conversation

justinba1010
Copy link

No description provided.

@justinba1010 justinba1010 requested a review from wyze January 19, 2020 03:28
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.125%
Totals Coverage Status
Change from base Build 9: 0.0%
Covered Lines: 24
Relevant Lines: 30
💛 - Coveralls

wyze
wyze approved these changes Feb 20, 2020
View reviewed changes
Copy link
Owner

@wyze wyze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is for BuckleScript v7 and no harm in having this for older versions as well. Thanks!

@wyze wyze merged commit 666581a into wyze:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyze wyze wyze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinba1010 @coveralls @wyze