Change type of cleanup function #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-ok
force-pushed
the
Change-type-of-cleanup-function
branch
2 times, most recently
from
cb4c4b0 to
630a989
Compare
denis-ok
force-pushed
the
Change-type-of-cleanup-function
branch
6 times, most recently
from
18c573e to
3c5f326
Compare
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 1 1
Lines 91 91
=======================================
Hits 90 90
Misses 1 1
Continue to review full report at Codecov.
|
denis-ok
force-pushed
the
Change-type-of-cleanup-function
branch
from
3c5f326 to
a864ee3
Compare
|
Looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return type for
cleanupfunction changed toJs.Promise.t(unit)according to source:https://github.com/testing-library/react-testing-library/blob/6833b8a0a78817782a0c4df3d8e33271c688e93e/src/pure.js#L99