Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for act helper function #17

Merged
merged 3 commits into from
Apr 12, 2020
Merged

Conversation

jihchi
Copy link
Contributor

@jihchi jihchi commented Apr 11, 2020

According to the doc from testing library:

act

This is a light wrapper around the react-dom/test-utils act function. All it does is forward all arguments to the act function if your version of react supports act.

This PR adds support for the function.

@coveralls

This comment has been minimized.

@codecov-io
Copy link

codecov-io commented Apr 12, 2020

Codecov Report

Merging #17 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   98.87%   98.90%   +0.02%     
==========================================
  Files           1        1              
  Lines          89       91       +2     
==========================================
+ Hits           88       90       +2     
  Misses          1        1              
Impacted Files Coverage Δ
src/ReactTestingLibrary.re 98.90% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b170630...cd9177f. Read the comment docs.

@wyze
Copy link
Owner

wyze commented Apr 12, 2020

Looks good, thanks again!

@wyze wyze merged commit 1eb4606 into wyze:master Apr 12, 2020
@jihchi jihchi deleted the add_supports_for_act branch April 13, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants