Integrated generated code for /v1/account_links #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, apologies for the late reply. We are working on getting up to speed on pull requests. May I ask if you are still interested in merging this (we are!) that you rebase? Thank you. As a general rule we should probably refrain from hand-editing the generated code, even though it deviates slightly from the spec, and instead look to change the codegen. |
|
Hi, I can definitely get it working with the current master branch sometime soon. I'll take a look at the generation first too :) |
|
Happy to give pointers if needed. |
|
What are the issues in the codegen that are causing the generated field names to be incorrect? Is it using an old schema of the API for generation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply includes the generated code and adds the
modandpub usestatements in resources.rs. One modification from the generated code was made for API compliance: the generatedAccountLinkTypeenum had the optionsCustomAccountUpdateandCustomAccountVerification, but I changed it toAccountUpdateandAccountOnboardingto match the API documented here. The resulting functionality was tested a decent amount and seems to work properly.