Support different email libraries #74
Conversation
|
@rktjmp Thanks for your patience ❤️. I know it's been a lot of back and forth but I think it's finally ready to be merged once the dialyzer issues are fixed and the conflict with master is resolved Let me know if there's something I can help with 🙌 BTW: you can run |
rktjmp
force-pushed
the
support-different-email-libraries
branch
from
c7f2f7e to
0fd8df2
Compare
|
Think its all good to go. I had to adjust the some dialyzer settings so it loaded the optional dependencies. |
| |> text_body(TextContent.build(error_info)) | ||
|
|
||
| options[:mailer].deliver_later!(email) | ||
| if Code.ensure_loaded?(Bamboo) do |
There was a problem hiding this comment.
https://elixirforum.com/t/is-there-a-guide-for-relying-on-optional-dependencies-in-a-library/37318
Seems to be the prescribed method, or at least, "not illegal". Without these checks downstream users get compiler errors when building boom.
There was a problem hiding this comment.
Yeah, I agree this is the way to do it (or at least I can't come up with a better way to do it)
|
Released in v0.7.0 |
|
🎉 |
rebasefrom master, See also: #71 #70 #61.It's been a moment since I was looking at this, just reopening to confirm it's not dead on my end.
Remaining tasks