fix: mail notifier subject length issue #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have an example of the subject that generated that error? Maybe besides truncating the length (that I'm favor of doing) we can also improve how we generate the subject |
|
@iaguirre88 If you try to render a html template that does not exists:
You will see that the reason will include all phoenix data and assigns. |
iaguirre88
reviewed
Oct 28, 2021
test: move reason tests, add subject tests
iaguirre88
previously approved these changes
Oct 28, 2021
|
@rafaeliga The CI is failing because of the linter. Would you mind you run |
Oops! done 👍 |
iaguirre88
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When sending an email, the reason is added to the subject, but there are cases that the reason has too much information.
When that happens, Bamboo returns this error:
** (Bamboo.ApiError) {:http_error, 400, %{code: "InvalidParameterValue", detail: "", message: "Header too long: 'Subject'.", request_id: "fb0db6bd-3130-4597-8ed8-313aaee84caf", type: "Sender"}} (bamboo 2.2.0) lib/bamboo/strategies/task_supervisor_strategy.ex:25: anonymous fn/3 in Bamboo.TaskSupervisorStrategy.deliver_later/3 (elixir 1.12.2) lib/task/supervised.ex:90: Task.Supervised.invoke_mfa/2 (stdlib 3.14.1) proc_lib.erl:226: :proc_lib.init_p_do_apply/3 Function: #Function<0.6361412/0 in Bamboo.TaskSupervisorStrategy.deliver_later/3>.My suggestion is that we have a config to handle that but at the same time always truncate the subject so it should work even without the new option.
I've added the full reason to the body so we don't lose that information.