Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http (fix): Properly report exception stack traces to server-side logs #3358

Merged
merged 3 commits into from
Jan 30, 2024

Fix for Scala 2

4ab696b
Select commit
Loading
Failed to load commit list.
Merged

http (fix): Properly report exception stack traces to server-side logs #3358

Fix for Scala 2
4ab696b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2024 in 0s

82.62% (target 80.00%)

View this Pull Request on Codecov

82.62% (target 80.00%)

Details

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (76dd486) 82.58% compared to head (4ab696b) 82.62%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3358      +/-   ##
==========================================
+ Coverage   82.58%   82.62%   +0.03%     
==========================================
  Files         355      354       -1     
  Lines       14899    14901       +2     
  Branches     2436     2458      +22     
==========================================
+ Hits        12305    12312       +7     
+ Misses       2594     2589       -5     
Files Coverage Δ
.../scala/wvlet/airframe/http/netty/NettyServer.scala 88.46% <100.00%> (+0.96%) ⬆️
...rc/main/scala/wvlet/airframe/http/HttpLogger.scala 37.03% <100.00%> (+2.42%) ⬆️
...src/main/scala/wvlet/airframe/http/RPCStatus.scala 86.41% <ø> (ø)
...airframe/http/client/HttpClientLoggingFilter.scala 83.33% <100.00%> (+8.33%) ⬆️
.../scala/wvlet/airframe/http/internal/HttpLogs.scala 91.93% <100.00%> (ø)
.../wvlet/airframe/http/internal/RPCCallContext.scala 100.00% <100.00%> (ø)
...let/airframe/http/internal/RPCResponseFilter.scala 75.00% <83.33%> (+5.76%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76dd486...4ab696b. Read the comment docs.