-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airframe-sql: Fix equi self-join #2819
airframe-sql: Fix equi self-join #2819
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2819 +/- ##
=======================================
Coverage 82.45% 82.45%
=======================================
Files 337 337
Lines 14273 14273
Branches 2312 2310 -2
=======================================
Hits 11769 11769
Misses 2504 2504
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qualifiers were not considered. Makes sense!
Certain queries containing equi self-join cannot be parsed:
The type resolver will end up throwing an exception, complaining about ambiguous column references. This is because the source code tries to match columns based on their source table. I guess it's to handle joins with unqualified attributes.
It took me a while to understand what the code was doing. I think that the matcher should not look at the source table name if a qualifier is present.