airframe-sql: Support EXTRACT function #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xerial
reviewed
Apr 3, 2023
|
Need to reformat the code with |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2818 +/- ##
==========================================
+ Coverage 82.43% 82.45% +0.02%
==========================================
Files 337 337
Lines 14249 14273 +24
Branches 2293 2312 +19
==========================================
+ Hits 11746 11769 +23
- Misses 2503 2504 +1
Continue to review full report in Codecov by Sentry.
|
xerial
reviewed
Apr 3, 2023
airframe-sql/src/main/scala/wvlet/airframe/sql/parser/SQLGenerator.scala
Outdated
Show resolved
Hide resolved
|
LGTM now! Thanks for your first contribution! I'll merge it after CI passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, queries containing
EXTRACTcannot properly be parsed asSQLInterpreterdoes not override thevisitExtractmethod. The default one ends up producing anullvalue when a function call is made inside theEXTRACTstatement. An exception is later thrown by the parser when it encounters thatnullvalue.This PR adds support for the
EXTRACTfunctions. It also adds support for additional intervals that need to be supported and it fixes an issue when generating grouping keys; function call would not be printed correctly.