Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-surface: Read default parameters in Scala 3 #2344

Merged
merged 10 commits into from
Jul 25, 2022

Conversation

xerial
Copy link
Member

@xerial xerial commented Jul 25, 2022

This change is necessary for Supporting Scala.js in Scala 3 #2202

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #2344 (be6b07c) into master (5419e65) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2344      +/-   ##
==========================================
- Coverage   82.79%   82.77%   -0.02%     
==========================================
  Files         341      341              
  Lines       13079    13082       +3     
  Branches      816      818       +2     
==========================================
  Hits        10829    10829              
- Misses       2250     2253       +3     
Impacted Files Coverage Δ
...cala/wvlet/airframe/codec/ScalaStandardCodec.scala 97.60% <ø> (ø)
...c/main/scala/wvlet/airframe/surface/Surfaces.scala 84.21% <0.00%> (-1.51%) ⬇️
.../main/scala-2/wvlet/airframe/surface/Surface.scala 80.00% <100.00%> (+5.00%) ⬆️
...rx/src/main/scala/wvlet/airframe/rx/RxRunner.scala 93.42% <0.00%> (-0.88%) ⬇️
...frame-rx/src/main/scala/wvlet/airframe/rx/Rx.scala 85.18% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5419e65...be6b07c. Read the comment docs.

@xerial xerial marked this pull request as ready for review July 25, 2022 20:28
@xerial xerial added this to the Scala 3 milestone Jul 25, 2022
@xerial xerial merged commit 75193e4 into master Jul 25, 2022
@xerial xerial deleted the scala3-default-value branch July 25, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant