Fix more warnings

wvanbergen · Oct 1, 2019 · 0ae09af · 0ae09af
1 parent 5dc5c99
commit 0ae09af
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/test/data_loss_test.rb b/test/data_loss_test.rb
@@ -33,17 +33,17 @@ def test_strict_mode_is_disabled
   end
 
   def test_decimal_silently_changes_out_of_bound_values
-    maximum = BigDecimal.new(10 **  (Unicorn.columns_hash['decimal'].precision - Unicorn.columns_hash['decimal'].scale))
-    delta   = BigDecimal.new(10 ** -(Unicorn.columns_hash['decimal'].scale), Unicorn.columns_hash['decimal'].precision)
+    maximum = BigDecimal(10 **  (Unicorn.columns_hash['decimal'].precision - Unicorn.columns_hash['decimal'].scale))
+    delta   = BigDecimal(10 ** -(Unicorn.columns_hash['decimal'].scale), Unicorn.columns_hash['decimal'].precision)
 
     refute_data_loss Unicorn.new(decimal: maximum - delta)
     assert_data_loss Unicorn.new(decimal: maximum)
     refute_data_loss Unicorn.new(decimal: 0 - maximum + delta)
     assert_data_loss Unicorn.new(decimal: 0 - maximum)
 
 
-    maximum = BigDecimal.new(10 **  (Unicorn.columns_hash['unsigned_decimal'].precision - Unicorn.columns_hash['unsigned_decimal'].scale))
-    delta   = BigDecimal.new(10 ** -(Unicorn.columns_hash['unsigned_decimal'].scale), Unicorn.columns_hash['unsigned_decimal'].precision)
+    maximum = BigDecimal(10 **  (Unicorn.columns_hash['unsigned_decimal'].precision - Unicorn.columns_hash['unsigned_decimal'].scale))
+    delta   = BigDecimal(10 ** -(Unicorn.columns_hash['unsigned_decimal'].scale), Unicorn.columns_hash['unsigned_decimal'].precision)
 
     refute_data_loss Unicorn.new(unsigned_decimal: maximum - delta)
     assert_data_loss Unicorn.new(unsigned_decimal: maximum)
@@ -99,7 +99,7 @@ def test_blob_field_silently_drops_bytes_when_when_over_bytesize_limit
   end
 
   def test_utf8mb3_field_sliently_truncates_strings_after_first_4byte_character
-    emoji = '💩'
+    emoji = "\u{1F4A9}"
     assert_equal 1, emoji.length
     assert_equal 4, emoji.bytesize
     assert_data_loss Unicorn.new(string: emoji)

diff --git a/test/database_constraints_validator_test.rb b/test/database_constraints_validator_test.rb
@@ -214,7 +214,7 @@ def unsigned_integer_range
   end
 
   def test_error_messages
-    foo = Foo.new(string: 'ü' * 41, checked: nil, not_null_text: '')
+    foo = Foo.new(string: 'ü' * 41, checked: nil, not_null_text: "\u{1F4A9}")
     refute foo.save
 
     assert_equal ["is too long (maximum is 40 characters)"], foo.errors[:string]