-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kafka 10 to newer alpine #289
Update kafka 10 to newer alpine #289
Conversation
Motivation - current version doesn't use /etc/resolv.conf which prevents kubernetes usage with the current image. See gliderlabs/docker-alpine#8
Dockerfile
Outdated
RUN /tmp/download-kafka.sh && \ | ||
tar xfz /tmp/kafka_${SCALA_VERSION}-${KAFKA_VERSION}.tgz -C /opt && \ | ||
rm /tmp/kafka_${SCALA_VERSION}-${KAFKA_VERSION}.tgz && \ | ||
rm -rf /var/cache/apk/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now in a separate layer, so won't save any space.
@@ -2,11 +2,16 @@ FROM anapsix/alpine-java | |||
|
|||
MAINTAINER Wurstmeister | |||
|
|||
RUN apk add --update unzip wget curl docker jq coreutils | |||
RUN echo "http://dl-cdn.alpinelinux.org/alpine/v3.7/main" > /etc/apk/repositories && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH - we plan to switch to the openjdk alpine image (something like #290) - so this shouldn't be required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sscaling would you prefer that I will switch to openjdk alpine image
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm saying that PR #290 supersedes this PR. So if we merge that, this can be closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YonatanKiron PR #290 is merged. Does this fix your issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sscaling Not really if it doesn't build older versions.
See I'm using wurstmeister/kafka:0.10.0.0
, so if you can rebuild the images somehow so it will actually take effect on the images that would be amazing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YonatanKiron - we're trying to position the current master branch so that we can hopefully unify master and release branches. This issue was raised a while ago: #163
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, yes I think it will fix my issue!
@@ -1,5 +1,5 @@ | |||
#!/bin/sh | |||
|
|||
mirror=$(curl --stderr /dev/null https://www.apache.org/dyn/closer.cgi\?as_json\=1 | jq -r '.preferred') | |||
mirror="https://archive.apache.org/dist/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have you removed mirror selection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually because 0.10.0.0
doesn't exists there (Take a look at http://apache.spd.co.il/kafka/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closer.cgi
just rotates through the various mirrors closest to you. So if a particular mirror doesn't have the requisite version of kafka, then retrying should eventually result in a mirror that does have the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be true, it doesn't exists in my region but I see what you are talking about
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps there's a better technique / algorithm to employ here? Or just make it user overridable - such as EXPLICIT_KAFKA_DOWNLOAD_MIRROR or similar?
Motivation - current version doesn't use /etc/resolv.conf which prevents
kubernetes usage with the current image.
See gliderlabs/docker-alpine#8