Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent configuration; Load and use proxy configuration. #61

Merged
merged 2 commits into from
May 21, 2024

Conversation

Jancis
Copy link
Member

@Jancis Jancis commented Apr 17, 2024

  • Provides config get and config set commands
  • Provides persistent configuration storage.
    • Linux location: /home/<user>/.config/silta/
    • Windows location: C:\Users\<user>\AppData\Local\silta\
    • Mac OS location: /Users/<user>/Library/Application Support/silta/
  • Sets http proxy environment variables in application scope whenever a non-empty proxy configuration item is found

Testing:

  1. Set context to a cluster that requires connection
  2. Load release information via silta ci release info --release-name <release-name> --namespace <namespace>. Should fail.
  3. Set proxy configuration silta config set proxy localhost:1234 (do not create tunnel yet).
  4. Load release information again. Should fail again but with a message "proxyconnect tcp: dial tcp [::1]:1234: connect: connection refused"
  5. Run ssh tunnel ssh -D 1234 -C -N <tunnel_host>
  6. Load release information, should succeed.

@Jancis Jancis force-pushed the feature/config-proxy branch from 4ec31d9 to 27062e0 Compare April 17, 2024 17:52
@Jancis Jancis marked this pull request as ready for review April 17, 2024 18:06
@Jancis Jancis requested a review from Rade333 April 17, 2024 18:06
Copy link
Contributor

@Rade333 Rade333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@Rade333 Rade333 merged commit 12d5829 into master May 21, 2024
24 checks passed
@Rade333 Rade333 deleted the feature/config-proxy branch May 21, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants