fix: remove slow brotli compression and use optimized gzip middleware #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarpTech
changed the title
jensneuse
approved these changes
Jul 26, 2024
StarpTech
changed the title
devsergiy
deleted the
dustin/eng-5489-remove-brotli-compression-due-to-very-slow-go-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR removes brotli compression support due to the very slow go implementation. Caddy the popular proxy solution made a similar decision. We will evaluate
zstdas a possible alternative in the future. For now only gzip is supported in the router. I also migrated to https://github.com/klauspost/compress/tree/master/gzhttp which is an optimized compression middleware for gzip. In my test the implementation was 100% faster than the current gzip middleware from chi.TODO