chore: improve demo dependency bumping and use dockertest for integration tests #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency ReviewThe following issues were found:
|
Router image scan passed✅ No security vulnerabilities found in image: |
endigma
force-pushed
the
jesse/1553-gomod-fix
branch
3 times, most recently
from
0769b96 to
5c8e500
Compare
StarpTech
reviewed
Feb 12, 2025
endigma
changed the title
endigma
changed the title
endigma
force-pushed
the
jesse/1553-gomod-fix
branch
from
664ede4 to
61353e0
Compare
endigma
changed the title
endigma
force-pushed
the
jesse/1553-gomod-fix
branch
3 times, most recently
from
4e31d50 to
c218ba6
Compare
StarpTech
requested changes
Feb 12, 2025
previously it attempted to share one kafka container across all parallel tests using a mutex and a global, but this poses major issues with shutdown, forcing a timed expiry, which is unreliable or slow depending on the constant expiry time
spinning up a kafka per test is theoretically safer and better for test isolation, but it slows down GHA so much that it makes timing dependent tests fail
endigma
force-pushed
the
jesse/1553-gomod-fix
branch
from
c218ba6 to
2ae7534
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #1553
bump-deps.shto use the head ofmainnot the current branch, which usually gets deleted on merge.router-teststo usedockertestinstead oftestcontainersfor booting up the Kafka server it uses forevents/*tests.Checklist