Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Code cleanup - rework proxy cookie handling in WebDriverType #286

Closed
mkrzyzanowski opened this issue Sep 21, 2018 · 2 comments
Closed

Code cleanup - rework proxy cookie handling in WebDriverType #286

mkrzyzanowski opened this issue Sep 21, 2018 · 2 comments
Assignees
@mkrzyzanowski
Labels
feature migration notes Contains migration notes
Milestone
2.0#2

Comments

@mkrzyzanowski
Copy link
Contributor

At the moment inside the WebDriverType we are adding a proxy cookie, a mechanism we have introduced to omit the firewall by adding a special cookie. It's a bit messy, done in two different places and not really configurable.

A reworked version should be utilising the modifier mechanism and provide a way to include multiple cookies from the configuration.
@mkrzyzanowski mkrzyzanowski self-assigned this Sep 21, 2018
@mkrzyzanowski
Copy link
Contributor Author

mkrzyzanowski commented Sep 24, 2018 •
edited
Loading

Changelog:

  • following properties removed:
    • webdriver.secure.proxy.cookie
    • webdriver.secure.proxy.cookie_name
    • webdriver.secure.proxy.cookie_value
    • webdriver.secure.proxy.cookie_domain
    • base.url
  • with the above, the old mechanism of adding a proxy cookie is removed
  • new mechanism for automated cookie loading has been introduced - loading a list of predefined cookies from a cookies.yaml file
    • the auto-loading does not fire when the file is not present or when the cookies.loadAutomatically is set to false

mkrzyzanowski added a commit that referenced this issue Sep 24, 2018
@mkrzyzanowski
#286 Added new way of adding cookies automatically
14c2843
mkrzyzanowski added a commit that referenced this issue Sep 24, 2018
@mkrzyzanowski
#286 Adjusted logic in integration tests to not affect other ones
e6673c0
mkrzyzanowski added a commit that referenced this issue Sep 24, 2018
@mkrzyzanowski
#286 Removed proxy cookie handling in WebDriverType; cleaned up tests…
f34f7b9 
… that were failing but were not run anyway
@mkrzyzanowski mkrzyzanowski mentioned this issue Sep 24, 2018
Merged
8 tasks
@mkrzyzanowski mkrzyzanowski added this to the 2.0#2 milestone Sep 25, 2018
mkrzyzanowski added a commit that referenced this issue Sep 27, 2018
@mkrzyzanowski
#286 added documentation for cookie loading mechanism
d5d20df
mkrzyzanowski added a commit that referenced this issue Sep 27, 2018
@mkrzyzanowski
#286 extended the cookie mechanism with ability to select which file …
bda30c6 
…is loaded; updated docs accordingly
@mkrzyzanowski mkrzyzanowski mentioned this issue Sep 27, 2018
Merged
8 tasks
mkrzyzanowski added a commit that referenced this issue Sep 27, 2018
@mkrzyzanowski
#286 Added javadocs + additional tests
ef6aae8
@mkrzyzanowski
Copy link
Contributor Author

Released in 1.6.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mkrzyzanowski mkrzyzanowski

Labels
feature migration notes Contains migration notes
Projects
None yet
Milestone
2.0#2
Development

No branches or pull requests
1 participant
@mkrzyzanowski