-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/security vulnerabilities #470
Merged
tkaik
merged 19 commits into
wttech:master
from
wblachowski:bugfix/security-vulnerabilities
Feb 15, 2019
Merged
Bugfix/security vulnerabilities #470
tkaik
merged 19 commits into
wttech:master
from
wblachowski:bugfix/security-vulnerabilities
Feb 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-suchorski
approved these changes
Jan 25, 2019
plutasnyy
added
the
QA Required
Requires manual tests, possible regression or impact on existing features.
label
Feb 1, 2019
Tested and accepted: QA Approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes security vulnerabilities reported by GitHub.
Description
Closes #407
Motivation and Context
Reported vulnerabilities in AET 3.2.0:
Most of these come from bower, which is deprecated for over a year now so no chances of it getting patched. For this reason I ditched bower altogether replacing it with npm for downloading dependencies + gulp-npm-copy-deps for copying them to the assets directory,
Apart from bower, gulp-sass, browserify and commons-fileupload had to be updated.
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.