Rerun suite, test, url #412

plutasnyy · 2018-10-23T13:52:36Z

Description

This PR provide you the functionality to rerun the whole suite - it runs in the same way like typical suite run, only test or url rerun - rerun part of suite work in a different way, after rerun, artifacts in your suite will be overwritten and aet doesn't create a new version of the suite.
The new way to run a test for page requires changes in the cleaner. The cleaner should remove overwritten artifacts- we don't want rubbish in our database. Functionality for the cleaner is in this PR

Motivation and Context

It would be a nice improvement for users

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

… feature/rerun

…s on update

… feature/rerun

…-test

lewandowskidawid · 2018-10-24T05:43:41Z

...communication-api/src/main/java/com/cognifide/aet/communication/api/metadata/Comparator.java

@@ -49,6 +50,9 @@ public void setStepResult(ComparatorStepResult stepResult) {
  }

  public List<Operation> getFilters() {
+    if(filters == null){


is it possible to pass the condition?

Thank you for the review ;)
Unfortunately, it is possible because the model in mongo has null when you saving empty array.
You can find more details here: discussion

lewandowskidawid · 2018-10-24T05:45:00Z

api/communication-api/src/main/java/com/cognifide/aet/communication/api/metadata/Suite.java

@@ -52,8 +54,12 @@
  private static final Type SUITE_TYPE = new TypeToken<Suite>() {
  }.getType();

+  public void setCorrelationId(String correlationId) {


why do we have the setter so high in the class?

lewandowskidawid · 2018-10-24T05:46:08Z

api/communication-api/src/main/java/com/cognifide/aet/communication/api/metadata/Suite.java

@@ -191,7 +208,7 @@ public String toString() {
        .toString();
  }

-  public void setVersion(long version) {
+  public void setVersion(Long version) {


is it expected that version could be null?

Yes,
I remember that it is strongly connected with updating version of a suite. Suite version is null during the first run of and typical run but during rerun, the suite has a version, so I needed to allow on setting empty version and set the same state like in a typical run. I didn't see a better way to set the correct suite's version during the rerun.

malaskowski

Could you please also update wiki SuiteReportFeatures docs and add some screenshots (e.g. those form the ticket description) and short note of the feature?
Also please update What's New with the short description or link to the Report Features Wiki Page.

malaskowski · 2018-10-25T08:41:04Z

api/communication-api/src/main/java/com/cognifide/aet/communication/api/metadata/Test.java

+        break;
+      }
+    }
+    return Optional.ofNullable(urlToReturn);


This is just cosmetics and your implementation is perfectly fine. But you could also do this method body with streams:

Suggested change

return Optional.ofNullable(urlToReturn);

return urls.stream()

.filter(url -> url.getName().equals(urlName))

.findFirst();

malaskowski · 2018-10-25T08:44:52Z

...ain/java/com/cognifide/aet/runner/processing/processors/SuiteExecutionProcessorStrategy.java

+
+public class SuiteExecutionProcessorStrategy extends ProcessorStrategy {
+
+  protected static final Logger logger = LoggerFactory


Name should be all upercase LOGGER a this is constant.

malaskowski · 2018-10-25T08:45:40Z

...main/java/com/cognifide/aet/runner/processing/processors/TestExecutionProcessorStrategy.java

+
+public class TestExecutionProcessorStrategy extends ProcessorStrategy {
+
+  protected static final Logger logger = LoggerFactory


Name should be all upercase LOGGER a this is constant.

malaskowski · 2018-10-25T08:45:47Z

.../main/java/com/cognifide/aet/runner/processing/processors/UrlExecutionProcessorStrategy.java

+
+public class UrlExecutionProcessorStrategy extends ProcessorStrategy {
+
+  protected static final Logger logger = LoggerFactory


Name should be all upercase LOGGER a this is constant.

…one/rerun-one-test # Conflicts: # CHANGELOG.md # rest-endpoint/src/main/java/com/cognifide/aet/rest/ArtifactServlet.java

…de/aet into milestone/rerun-one-test

plutasnyy · 2018-10-29T12:33:27Z

Thank you for help with documentation and review

tkaik · 2018-11-05T07:37:28Z

CHANGELOG.md

@@ -18,6 +18,7 @@ All notable changes to AET will be documented in this file.
 - [PR-396](https://github.com/Cognifide/aet/pull/396) Added horizontal scrollbar for wide pages ([#393](https://github.com/Cognifide/aet/issues/393)) 
 - [PR-403](https://github.com/Cognifide/aet/pull/403) Conditionally passed tests can be accepted ([#400](https://github.com/Cognifide/aet/issues/400))
 - [PR-387](https://github.com/Cognifide/aet/pull/387) Set max allowed page screenshot height to 35k pixels.
+- [PR-412](https://github.com/Cognifide/aet/pull/412) ([PR-336](https://github.com/Cognifide/aet/pull/336), [PR-337](https://github.com/Cognifide/aet/pull/337), [PR-395](https://github.com/Cognifide/aet/pull/395)) - Added rerun functionality for suite, test and url 


@plutasnyy Please move this entry to "Unreleased" section

Slasheruus · 2018-11-08T13:42:09Z

Tested (/)

plutasnyy and others added 30 commits August 16, 2018 18:47

start work with rerun, create base for new servlet

a381d76

restored old annotataions, add register servlet

386273c

prototype

1526443

communication front - back

2e096a5

added test to payload

010593b

first version of endpoint to execute rerun

a6198eb

merge

556f061

restored addCors in suite rerun srvlet

e0bd59b

communication front - back refactor

fbd14d9

work on rerun servlet

956dcfa

Merge branch 'feature/rerun' of https://github.com/Cognifide/aet into…

278d22b

… feature/rerun

upadted suite executor

c22ccee

cleared data in received suite

f9d9660

small refactor to make servlet human readable

aa1d99d

added replacing test in database

fd39331

refactor

20395cb

refactor

48c1563

license & refactor

b421341

annotations fix

73b0abd

SuiteRerun update

6715f59

fixed clean daara from suite

988f255

changed overriding one test in mongo db from remove and add operation…

c020d2f

…s on update

merged with master, updated annotations to 6.0

d4b3350

removed scr from rest-endpoint and resolved conflicts

f7ca219

merged with history and resolved conflicts

bdf2fb9

added gson object in reponseAsJson calls

0765aae

resolved conflicts

deb4cc9

rerun all tests

140869e

Merge branch 'feature/rerun' of https://github.com/Cognifide/aet into…

0e9c74a

… feature/rerun

rerun button on suite level

fb8e612

plutasnyy added 3 commits October 23, 2018 15:33

Merge remote-tracking branch 'origin/master' into milestone/rerun-one…

7a2bbf2

…-test

updated changelog

537c3c6

updated changelog

3fd1cb1

plutasnyy requested review from malaskowski, PiteroS678 and tkaik October 23, 2018 13:55

lewandowskidawid reviewed Oct 24, 2018

View reviewed changes

plutasnyy and others added 2 commits October 24, 2018 12:35

Merge branch 'master' into milestone/rerun-one-test

c2ad82f

moved setCorerlationID lower

17d9c71

malaskowski reviewed Oct 25, 2018

View reviewed changes

tkaik and others added 5 commits October 25, 2018 12:22

Merge branch 'master' of https://github.com/Cognifide/aet into milest…

b3a3eff

…one/rerun-one-test # Conflicts: # CHANGELOG.md # rest-endpoint/src/main/java/com/cognifide/aet/rest/ArtifactServlet.java

update docs

27b5f3f

changed logger to uppercase and refactored getUrl function in Test class

df2edf4

Merge branch 'milestone/rerun-one-test' of https://github.com/Cognifi…

741e59f

…de/aet into milestone/rerun-one-test

resolved conflicts

bc95428

tkaik reviewed Nov 5, 2018

View reviewed changes

fixed changelog

67955be

malaskowski added the QA Required Requires manual tests, possible regression or impact on existing features. label Nov 7, 2018

Slasheruus closed this Nov 8, 2018

Slasheruus reopened this Nov 8, 2018

tkaik approved these changes Nov 8, 2018

View reviewed changes

tkaik merged commit 8f9698d into master Nov 8, 2018

tkaik deleted the milestone/rerun-one-test branch November 8, 2018 14:01

tkaik mentioned this pull request Nov 27, 2018

Remove redundant changes in test-suite partials from rerun milestone branch #444

Merged

5 tasks

wblachowski mentioned this pull request Feb 1, 2019

Add tooltip for the re-run button in Report #476

Closed

wblachowski mentioned this pull request Oct 2, 2019

Add sending urls in packets #526

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rerun suite, test, url #412

Rerun suite, test, url #412

plutasnyy commented Oct 23, 2018 •

edited

Loading

lewandowskidawid Oct 24, 2018

plutasnyy Oct 24, 2018

lewandowskidawid Oct 24, 2018

plutasnyy Oct 24, 2018

lewandowskidawid Oct 24, 2018

plutasnyy Oct 24, 2018

malaskowski left a comment

malaskowski Oct 25, 2018

malaskowski Oct 25, 2018

malaskowski Oct 25, 2018

malaskowski Oct 25, 2018

plutasnyy commented Oct 29, 2018

tkaik Nov 5, 2018

plutasnyy Nov 7, 2018

Slasheruus commented Nov 8, 2018

-    return Optional.ofNullable(urlToReturn);
+    return urls.stream()
+        .filter(url -> url.getName().equals(urlName))
+        .findFirst();


		public class SuiteExecutionProcessorStrategy extends ProcessorStrategy {

		protected static final Logger logger = LoggerFactory


		public class TestExecutionProcessorStrategy extends ProcessorStrategy {

		protected static final Logger logger = LoggerFactory


		public class UrlExecutionProcessorStrategy extends ProcessorStrategy {

		protected static final Logger logger = LoggerFactory

Rerun suite, test, url #412

Rerun suite, test, url #412

Conversation

plutasnyy commented Oct 23, 2018 • edited Loading

Description

Motivation and Context

Screenshots (if appropriate):

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

malaskowski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

plutasnyy commented Oct 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Slasheruus commented Nov 8, 2018

plutasnyy commented Oct 23, 2018 •

edited

Loading