Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NPE in Cleaner Scheduler after migrating to OSGi 6 #350

Merged
merged 3 commits into from
Sep 13, 2018

Conversation

malaskowski
Copy link
Contributor

Description

After #326 company and project in the cleaner configuration didn't provide non-null default value and caused:

aet_karaf.1.nkvm7vv3tis4@default    | 12:26:32.716 ERROR [fileinstall-/opt/karaf/deploy] Fatal error while activating cleaner scheduler
aet_karaf.1.nkvm7vv3tis4@default    | java.lang.NullPointerException: null value in entry: companyFilter=null
aet_karaf.1.nkvm7vv3tis4@default    |   at com.google.common.collect.CollectPreconditions.checkEntryNotNull(CollectPreconditions.java:32)
aet_karaf.1.nkvm7vv3tis4@default    |   at com.google.common.collect.ImmutableMap.entryOf(ImmutableMap.java:176)
aet_karaf.1.nkvm7vv3tis4@default    |   at com.google.common.collect.ImmutableMap$Builder.put(ImmutableMap.java:285)
aet_karaf.1.nkvm7vv3tis4@default    |   at com.cognifide.aet.cleaner.CleanerScheduler.registerCleaningJob(CleanerScheduler.java:123)

Before empty string values were provided.

Motivation and Context

Fixed NPE.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

@malaskowski malaskowski added the bug label Sep 3, 2018
@tkaik tkaik merged commit f961e82 into master Sep 13, 2018
@tkaik tkaik deleted the bugfix/fix-npe-in-cleaner-config branch September 13, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants