Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double slash comments are silently breaking script execution #388

Closed
jakub-przybytek-wttech opened this issue Jan 18, 2023 · 0 comments · Fixed by #393
Closed

Double slash comments are silently breaking script execution #388

jakub-przybytek-wttech opened this issue Jan 18, 2023 · 0 comments · Fixed by #393

Comments

@jakub-przybytek-wttech
Copy link

When I applied comment starting with double slash (which is wrong, I know) my script didn't end with error but silently break the execution instead, see:

Some valid APM commands that were successfully executed

// wrong comment starting characters

Some valid APM commands that wasn't executed at all

I think, that ff double slash is not valid syntax of APM then it should break the run.
dprzybyl added a commit that referenced this issue Jul 4, 2023
@dprzybyl
Double slash comments are silently breaking script execution #388
3904e0e
dprzybyl added a commit that referenced this issue Jul 4, 2023
@dprzybyl
Double slash comments are silently breaking script execution #388
84e9a61
@dprzybyl dprzybyl linked a pull request Jul 4, 2023 that will close this issue
double slash comments are silently breaking script execution #388 #393
Merged
dprzybyl added a commit that referenced this issue Jul 5, 2023
@dprzybyl
Double slash comments are silently breaking script execution #388
85a1cd2
dprzybyl added a commit that referenced this issue Jul 5, 2023
@dprzybyl
Merge pull request #393 from wttech/388-double-slash-comments-are-sil…
3bb322e 
…ently-breaking-script-execution

double slash comments are silently breaking script execution #388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

double slash comments are silently breaking script execution #388 wttech/APM
1 participant
@jakub-przybytek-wttech