Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing declarations for controlled vocabularies, rather than free strings in Heron metadata client #578

Open
kjsanger opened this issue Apr 22, 2020 · 0 comments

Comments

@kjsanger
Copy link
Member

npg_pipeline::product::heron::upload::library line 14, package-level variable
our $NEB_ULTRA = q(NEB Ultra II);
in bin/npg_heron_metadata_upload, line 160, assignment of default
$sequencing_kit ||= 'NEB Ultra II';
To minimise repetition and guard against typos in further edits, could be
$sequencing_kit ||= $npg_pipeline::product::heron::upload::library::NEB_ULTRA;

Separate package with constants, which are private variable that are exported on demand or for a config file?

@kjsanger kjsanger changed the title Use existing declarations for controlled vocabularies, rather than free strings Use existing declarations for controlled vocabularies, rather than free strings in Heron metadata client Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant