Fix feed sorting issue and extra line issue with hightlightable text widget #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyingfan
changed the title
|
Thanks for the PR! DO has changed how Hacktoberfest works: https://hacktoberfest.digitalocean.com/hacktoberfest-update and your PRs are exactly the kind that Hacktoberfest was intended for, ones that make things better for everyone. So if you do choose to, they'll count :) (Full disclosure: I work for DigitalOcean) |
This was referenced Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #958 and #900
#958: in a mix of feeds with and without published date, the ones without published date will appear op top of those with published date.
#900:
text.HighlightableHelper()always append a LF character to the input. So trimming whitespace in the text widget would help.PS: I am really not doing this for the shitoberfest t-shirt :P