Explicitly set the default config file's mode to 0600 #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senorprogrammer
force-pushed
the
20190725-chmod-0600-config-file
branch
from
d849f6c to
23c54b6
Compare
senorprogrammer
force-pushed
the
20190725-chmod-0600-config-file
branch
from
23c54b6 to
50cc966
Compare
| } | ||
|
|
||
| func displayDefaultConfigWriteError(err error) { | ||
| fmt.Printf("\n%s Could not write the default configuration.\n", aurora.Red("ERROR:")) |
There was a problem hiding this comment.
I think this is a little obtuse, considering we throw it when permissions are incorrect. We should explicitly call out permissions here I think?
There was a problem hiding this comment.
This error will happen if the default config.yml cannot be written for any reason into ~/.config/wtf/ on first create.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.