Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal display when editing a Todo item is very slow #876

Closed
senorprogrammer opened this issue Apr 14, 2020 · 0 comments
Closed

Modal display when editing a Todo item is very slow #876

senorprogrammer opened this issue Apr 14, 2020 · 0 comments
Labels
🐛 bug "Houston, we've had a problem." 👍 confirmed

Comments

@senorprogrammer
Copy link
Collaborator

What's broken?

Opening the modal for a new item is relatively fast. Opening the modal to edit an existing item is very slow. Figure out what the difference between them is. They should be the same speed (and that should feel fast).
@senorprogrammer senorprogrammer added the 🐛 bug "Houston, we've had a problem." label Apr 14, 2020
aeter added a commit to aeter/wtf that referenced this issue Jul 24, 2020
@aeter
Close wtfutil#876 - fix todo modal editing feeling slow
ea78904 
Fixes wtfutil#876. The modal shown when editing todos was feeling slow to start
It required an additional hit of `Enter` to show the modal.

This commit fixes it by queueing a `Draw` update - so now the modal
feels fast to show.

Tests:
* ran `make test`
* tested locally with a todo list
@aeter aeter mentioned this issue Jul 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug "Houston, we've had a problem." 👍 confirmed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@senorprogrammer