Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HackerNews issue with stories #758

Closed
BartoszCoyote opened this issue Nov 20, 2019 · 0 comments · Fixed by #802
Closed

HackerNews issue with stories #758

BartoszCoyote opened this issue Nov 20, 2019 · 0 comments · Fixed by #802
Labels
💪 improvement "Where we're going, we don't need roads."

Comments

@BartoszCoyote
Copy link

What's broken?

Stories without external links should open hacker news website but instead, nothing happened.
@senorprogrammer senorprogrammer added the 💪 improvement "Where we're going, we don't need roads." label Nov 20, 2019
senorprogrammer added a commit that referenced this issue Dec 28, 2019
@senorprogrammer
WTF-758 Open HN comments if there's no external link
c002cc0 
If an HN story has no external link associated with it,
open the HN comments page for the story.

Closes #758

Signed-off-by: Chris Cummer <[email protected]>
@senorprogrammer senorprogrammer mentioned this issue Dec 28, 2019
Merged
senorprogrammer added a commit that referenced this issue Dec 28, 2019
@senorprogrammer
WTF-758 Open HN comments if there's no external link
1c8d411 
If an HN story has no external link associated with it,
open the HN comments page for the story.

Closes #758

Signed-off-by: Chris Cummer <[email protected]>
senorprogrammer added a commit that referenced this issue Dec 31, 2019
@senorprogrammer
WTF-758 Open HN comments if there's no external link (#802)
e679a98 
If an HN story has no external link associated with it,
open the HN comments page for the story.

Closes #758

Signed-off-by: Chris Cummer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💪 improvement "Where we're going, we don't need roads."
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WTF-758 Open HN comments if there's no external link wtfutil/wtf
2 participants
@senorprogrammer @BartoszCoyote