Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esc key does not dismiss modal dialog in Todo #520

Closed
senorprogrammer opened this issue Jul 29, 2019 · 5 comments
Closed

Esc key does not dismiss modal dialog in Todo #520

senorprogrammer opened this issue Jul 29, 2019 · 5 comments
Labels
🐛 bug "Houston, we've had a problem."

Comments

@senorprogrammer
Copy link
Collaborator

The Esc key should dismiss the modal dialog in the Todo module. It no longer does.
@senorprogrammer senorprogrammer added the 🐛 bug "Houston, we've had a problem." label Jul 29, 2019
@senorprogrammer
Copy link
Collaborator Author

Tab key should also move between fields/buttons. No longer does.

@Seanstoppable
Copy link
Collaborator

As far as I can tell, the top level keybindings are stopping widget level keybindings. Potentially a problem with the way I restructured some of the code. I'll try to dig in this weekend.

@Seanstoppable
Copy link
Collaborator

It actually has to do with this code block:
https://github.com/wtfutil/wtf/blob/master/app/wtf_app.go#L83-L95

The 'return nil' means that the key doesn't flow through to the widgets themselves.

Seanstoppable added a commit to Seanstoppable/wtf that referenced this issue Aug 4, 2019
@Seanstoppable
Fix keyboard fallthrough
10772c2 
We are expecting Esc and Tab to perform other actions, so these need to not return nil
Addresses wtfutil#520
@Seanstoppable Seanstoppable mentioned this issue Aug 4, 2019
Merged
@Seanstoppable
Copy link
Collaborator

Opened a PR where the behavior appears to be correct (at least for TODO). Tab doesn't cycle through when the window captures it. Esc seems to work appropriately

@senorprogrammer
Copy link
Collaborator Author

Fixed by #523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug "Houston, we've had a problem."
Milestone
No milestone
Development

No branches or pull requests
2 participants
@senorprogrammer @Seanstoppable