Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins Green Balls #358

Closed
skymeyer opened this issue Jan 19, 2019 · 5 comments
Closed

Jenkins Green Balls #358

skymeyer opened this issue Jan 19, 2019 · 5 comments
Labels
🥇 good first issue 💪 improvement "Where we're going, we don't need roads."

Comments

@skymeyer
Copy link
Contributor

Successful builds in the Jenkins module are using the blue color. Would like to add the option to use green instead of blue to mimic https://wiki.jenkins.io/display/JENKINS/Green+Balls.

Proposal

  • Add a boolean greenBalls config parameter to use green instead of blue in reference to the green balls plugin
  • Or add config parameters to be able to customize each colors

Thoughts ?
@senorprogrammer senorprogrammer added the 💪 improvement "Where we're going, we don't need roads." label Jan 23, 2019
@senorprogrammer
Copy link
Collaborator

Default to blue with the option to change to whatever colour the user wants?

@rudolphjacksonm
Copy link
Contributor

Hi folks--I'm learning Go and this seems like a good issue to take a stab at. @skymeyer having a boolean config parameter seems like the easiest place to start. Are you ok with me taking a look at this?

@rudolphjacksonm rudolphjacksonm mentioned this issue Apr 15, 2019
Merged
@rudolphjacksonm
Copy link
Contributor

Also opened a PR for the wtfutildocs, see wtfutil/wtfdocs#21

@senorprogrammer
Copy link
Collaborator

Thanks for tackling this one!

senorprogrammer added a commit that referenced this issue Apr 15, 2019
@senorprogrammer
Merge pull request #403 from rudolphjacksonm/patch-1
54201a2 
Jenkins Green Balls Plugin Support - #358
@senorprogrammer
Copy link
Collaborator

Closed with #403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🥇 good first issue 💪 improvement "Where we're going, we don't need roads."
Milestone
No milestone
Development

No branches or pull requests
3 participants
@senorprogrammer @skymeyer @rudolphjacksonm