Fix bug in the "np" function. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slicing the variable "s" when returning causes the link not to appear properly since such slicing remove the closing square bracket. This issue would not raise if there is a blank line after the link. So to avoid adding a blank line after a link specifically at the end of a file such slicing on the variable "s" is removed.
|
Have verified the bug and the solution. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slicing the variable "s" when returning causes the link not to appear properly since such slicing remove the closing square bracket. This issue would not raise if there is a blank line after the link. So to avoid adding a blank line after a link specifically at the end of a file such slicing on the variable "s" is removed.
The attached zipped file contains a jemdoc file using which this issue can be reproduced.
ReproduceBug_PR#3.zip
The following images also compare the before/after resolving the issue.
