-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using native unit checks from MTK #44
Conversation
unit tests and doc examples need updating |
Edit: MTK has been patched so that we can disable the standard unit checking when lowering to Native MTK unit checking won't work unless we require users to first write all of their rate equations for ion channels as Julia functions first then I've submitted a PR upstream with a fix that could work. If that's not approved, we could either:
|
This will definitely break until the next version of MTK gets tagged. (master branch has fixes that enable latest commits here) |
fixes #5
Deprecates the use of
ConductorUnits
in favor of the unit metadata and validation baked into ModelingToolkit.jlThe setup for channel rates are more involved now, since we have to do multiple overloads. This should get fixed with a macro that automatically does the required registration and overloading automatically.