Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build issue with JDK 11 #404

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Fix build issue with JDK 11 #404

merged 1 commit into from
Feb 14, 2023

Conversation

Shalindri
Copy link
Contributor

@Shalindri Shalindri commented Feb 14, 2023 •
edited
Loading

Purpose

org.wso2.carbon.identity.customhandler is not getting built when using JDK 11

Approach

Remove and upgrade a unsupported dependency version

@deshankoswatte
Copy link
Member

deshankoswatte commented Feb 14, 2023 •
edited
Loading

Previous PR with the rest of the changes done for another component: #403.

Thumimku
Thumimku approved these changes Feb 14, 2023
View reviewed changes
Copy link

@Thumimku Thumimku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the correct version from the parent pom.

@deshankoswatte deshankoswatte merged commit 8359ca9 into wso2:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deshankoswatte deshankoswatte deshankoswatte approved these changes

@Thumimku Thumimku Thumimku approved these changes

@yogyagamage yogyagamage Awaiting requested review from yogyagamage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shalindri @deshankoswatte @Thumimku