Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set circuitbreaker if org is paid #3626

Open
wants to merge 5 commits into
base: choreo
Choose a base branch
from

Conversation

Thushani-Jayasekera
Copy link

@Thushani-Jayasekera Thushani-Jayasekera commented Dec 11, 2024

Purpose

Issues

Fixes #
Relates to https://github.com/wso2-enterprise/choreo/issues/32018

Automation tests

  • Unit tests added: Yes/No
  • Integration tests added: Yes/No

Tested environments

Not Tested


Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

@Thushani-Jayasekera Thushani-Jayasekera changed the title set circuitbreaker if org is paid [WIP] set circuitbreaker if org is paid Dec 11, 2024
@renuka-fernando renuka-fernando self-assigned this Dec 11, 2024
@Thushani-Jayasekera Thushani-Jayasekera changed the title [WIP] set circuitbreaker if org is paid Set circuitbreaker if org is paid Dec 11, 2024
@@ -113,7 +115,7 @@ func PushAPIProjects(payload []byte, environments []string, xdsOptions common.Xd
// Pass the byte slice for the XDS APIs to push it to the enforcer and router
// TODO: (renuka) optimize applying API project, update maps one by one and apply xds once
var deployedRevisionList []*notifier.DeployedAPIRevision
deployedRevisionList, err = apiServer.ApplyAPIProjectFromAPIM(apiFileData, vhostToEnvsMap, envProps, xdsOptions)
deployedRevisionList, err = apiServer.ApplyAPIProjectFromAPIM(apiFileData, vhostToEnvsMap, envProps, xdsOptions, choreoComponentInfo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
deployedRevisionList, err = apiServer.ApplyAPIProjectFromAPIM(apiFileData, vhostToEnvsMap, envProps, xdsOptions, choreoComponentInfo)
deployedRevisionList, err = apiServer.ApplyAPIProjectFromAPIM(apiFileData, vhostToEnvsMap, envProps, xdsOptions, deployment.ChoreoComponentInfo)

Comment on lines 98 to 99
choreoComponentInfo := deployment.ChoreoComponentInfo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
choreoComponentInfo := deployment.ChoreoComponentInfo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants