Add CIBA success page #7685
Open
Add CIBA success page #7685
+131
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@wso2is/identity-apps-core": patch | |||
There was a problem hiding this comment.
Since this is an improvement, let's update to minor
Suggested change
| "@wso2is/identity-apps-core": patch | |
| "@wso2is/identity-apps-core": minor |
| @@ -462,6 +467,11 @@ | |||
| <url-pattern>/device_success.do</url-pattern> | |||
| </servlet-mapping> | |||
|
|
|||
| <servlet-mapping> | |||
| <servlet-name>ciba_success.do</servlet-name> | |||
| <url-pattern>/ciba_success.do</url-pattern> | |||
There was a problem hiding this comment.
This will make ciba_success url appear in the end user's browser. Showing an unnecessary tech term wouldn't look good IMO. Shall we use a generic yet relevant name instead?
| @@ -0,0 +1,115 @@ | |||
| <%-- | |||
| ~ Copyright (c) 2019-2023, WSO2 LLC. (https://www.wso2.com). | |||
There was a problem hiding this comment.
Suggested change
| ~ Copyright (c) 2019-2023, WSO2 LLC. (https://www.wso2.com). | |
| ~ Copyright (c) 2025, WSO2 LLC. (https://www.wso2.com). |
| <% } %> | ||
| </head> | ||
| <body class="login-portal layout authentication-portal-layout" onload="loadFunc()"> | ||
| <layout:main layoutName="<%= layout %>" layoutFileRelativePath="<%= layoutFileRelativePath %>" data="<%= layoutData %>" > |
There was a problem hiding this comment.
Suggested change
| <layout:main layoutName="<%= layout %>" layoutFileRelativePath="<%= layoutFileRelativePath %>" data="<%= layoutData %>" > | |
| <layout:main layoutName="<%= layout %>" layoutFileRelativePath="<%= layoutFileRelativePath %>" data="<%= layoutData %>"> |
| <p class="portal-tagline-description"> | ||
| <%=AuthenticationEndpointUtil.i18n(resourceBundle, "login.success.app")%> | ||
| <%= Encode.forHtmlAttribute(request.getParameter("app_name"))%> | ||
| <%=AuthenticationEndpointUtil.i18n(resourceBundle, "close.browser")%> |
There was a problem hiding this comment.
Let's use the new i18n function from localize.jsp here.
Ref:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7685 +/- ##
=======================================
Coverage 41.85% 41.85%
=======================================
Files 42 42
Lines 939 939
Branches 238 217 -21
=======================================
Hits 393 393
Misses 546 546
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$subject
Related Issues
Related PRs