Fix TFSec Recommendations #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VimukthiPerera
previously approved these changes
Oct 12, 2023
DilanUA
reviewed
Oct 12, 2023
modules/aws/ECR-IAM-User/iam_role.tf
Outdated
| @@ -14,6 +14,8 @@ resource "aws_iam_user" "ecr_access_user" { | |||
| tags = var.tags | |||
| } | |||
|
|
|||
| # Ignoring as this IAM User is an Admin user used for accessing any ECR repository | |||
There was a problem hiding this comment.
In this comment, can you also add what AVD-AWS-0057 is about and the reason for ignoring this is not clear.
There was a problem hiding this comment.
Better to add the documentation link for this violation if there is anything as such.
There was a problem hiding this comment.
Shall we some specific format for this like the one below? it's easy to review then
# Ignore AVD-AWS-0057 (https://avd.aquasec.com/misconfig/aws/iam/avd-aws-0057):
# Reason: Ignoring as this IAM User is an Admin user used for accessing any ECR repository
# trivy:ignore:AVD-AWS-0057
ranikamadurawe
force-pushed
the
main-fix
branch
from
fd819d5 to
8a4eeb8
Compare
DilanUA
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/wso2-enterprise/cloud-sre-common/issues/404