Change implementation for adding user realm to username in password recovery flow. #803
Conversation
|
PR builder started |
|
PR builder completed |
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7735832027
RushanNanayakkara
force-pushed
the
master
branch
from
21775e7
to
3c5fcf1
Compare
...main/java/org/wso2/carbon/identity/recovery/endpoint/impl/RecoverPasswordApiServiceImpl.java
Outdated
Show resolved
Hide resolved
...main/java/org/wso2/carbon/identity/recovery/endpoint/impl/RecoverPasswordApiServiceImpl.java
Outdated
Show resolved
Hide resolved
...main/java/org/wso2/carbon/identity/recovery/endpoint/impl/RecoverPasswordApiServiceImpl.java
Outdated
Show resolved
Hide resolved
|
PR builder started |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
RushanNanayakkara
force-pushed
the
master
branch
from
ab716d9
to
754a784
Compare
Purpose
The current implementation does not add the user realm to the username before the initial user search is conducted through MultiAttributeLoginService. It also does not check if the user realm is not passed at all. This could result in appending user realm as null to the username, which results in a failed search. Additionally if the "PRIMARY" is passed as the realm name in the request wrongly, this implementation still searches through all the user stores and finds the user in a different userstore since UserCoreUtil.addDomainToName function skips adding domain name if it's "PRIMARY". This PR fixes all mentioned issues above.
Related Issues
Dependent PR