Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required packages to the singularity definition file #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rsuwa
Copy link

@rsuwa rsuwa commented Jan 14, 2020

Updated the ray package in the Singularity definition file because the ray package is out of date and does not work under a Singularity container environment. I also added the missing Python package. It works in conjunction with #7.

I'm sorry for my poor English. 🙇

@rsuwa rsuwa requested a review from wsjeon January 16, 2020 05:39
@jkterry1
Copy link

What prompts this line: apt-get install -y libsm6 libxext6?

@jkterry1
Copy link

jkterry1 commented Jan 18, 2020

Also, does switching from 8dev2 to 8dev7 change anything for this?

For context, this repo isn't being maintained, so I'm creating an official fork of this that actually works per ray-project/ray#6803.

@jkterry1
Copy link

Also, is there a way to specify the python package version in the singularity file?

@rsuwa
Copy link
Author

rsuwa commented Jan 23, 2020

@justinkterry

Also, does switching from 8dev2 to 8dev7 change anything for this?

For context, this repo isn't being maintained, so I'm creating an official fork of this that actually works per ray-project/ray#6803.

In 8dev2, ray.rllib.contrib.maddpg.maddpg is not available.

What prompts this line: apt-get install -y libsm6 libxext6?

Failure to install these packages will result in errors when calling opencv from python.

Also, is there a way to specify the python package version in the singularity file?

You need to add apt-get install python3.x to the Singularity definition file and change this version to be used by default.

@jkterry1
Copy link

Sure, but 8.0>8devx, which is what I'm using in the new official repo (https://github.com/justinkterry/maddpg-rllib).

Since when is opencv required by any of this code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants