Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/text node sibling bluecheck #58

Merged
merged 5 commits into from
Nov 17, 2022
Merged

Conversation

noway
Copy link
Collaborator

@noway noway commented Nov 17, 2022

Fix the case when a blue check is neighbouring a React text node

In majority of cases, a blue check is its own React element inside of a parent React element.
In a few cases such as Notifications tab, a blue check is neighbouring a React text node.

Before:
image

After:
image

@noway noway requested a review from wseagar November 17, 2022 10:43
@wseagar wseagar merged commit de40a0e into main Nov 17, 2022
@noway noway deleted the fix/text_node_sibling_bluecheck branch November 18, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants