Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/classes retainment #56

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Fix/classes retainment #56

merged 4 commits into from
Nov 15, 2022

Conversation

noway
Copy link
Collaborator

@noway noway commented Nov 15, 2022

Fix for a small bug introduced in #46.

When a node gets mutated (rather than added), the code would set the check mark classname to undefined instead of the right one.

Fixed by retaining the original class of the node in data-eight-dollars-original-classes attribute.

Test case:

Before:
image
image
image

After:
image
image
image

Bug scope:
The bug is only affecting "Enable Text" mode. The icon-only mode worked fine. I don't think anyone reported this yet.

@noway noway requested a review from wseagar November 15, 2022 06:15
@wseagar wseagar merged commit 18485f5 into main Nov 15, 2022
@noway noway deleted the fix/classes_retainment branch November 15, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants