Fix plant owner names and add LEI codes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing part of issue 24, add a new field (`lei_code`) to the output database. This field holds a reference to a plant's unique LEI in the GLEIF dataset. This should allow users to connect plant data to LEI ownership information and ISINs (unique financial instruments). The `lei_code` field is an alphanumeric string matched to power plants using the `master_gleif_concordance.csv` dataset. With this update, there are 8132 plants with known `lei_code`s. There are no changes to the database except for the addition of `lei_code`. Database Version: 1.2.3
Bug: The Denmark.csv dataset contains data that quantifies ownership with a percentage, rather than just the name of the entity. For example, data provided by Vattenfall prepends owner names with their percent ownership (100% Vattenfall instead of Vattenfall). This can cause issues with programs that expect owner data to be the entity name only. This commit fixes this bug. There are 8 plants affected, all in Denmark. Net change of 0 plants @ 0 capacity. Database Version: 1.2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The database displays the name in the owner field with a percentage. For some Denmark plants, the percentage ownership is included in the owner name. For example, a plant wholly owned by Vattenfall may have the owner name reported as '100% Vattenfall' instead of 'Vattenfall'. The database does not join well with owner data from the GLEIF database.
Issue Number: 24 and 27
What is the new behavior?
resources/master_lei_concordance.csvis used to match and append LEI codes to the database output in a new column labeledlei_code.Does this introduce a breaking change?
Other information