Rework the dependency linking of hydro CMake compilation

[islas]

TYPE: bug fix

KEYWORDS: cmake, hydro

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Some dependencies were not being fully satisfied and were implicit / partially fulfilled by subsequent compilation. In compilers that could tolerate these situations the hydro folder would compile successfully.

However, for compilers where dependencies are enforced (i.e. symbols resloved at compile time even within Fortran submodules), compilation would fail.

Solution:
To account for situations where compilers require all module dependencies be resolved, dependencies between the hydro libraries and the transitive link properties were reworked to propagate dependencies up the chain correctly.

TESTS CONDUCTED:

1. Tested building hydro with Intel oneAPI ifx 2024.2.1

RELEASE NOTE:
Fixed failed compilation with Intel oneAPI by reworking the dependency linking of hydro CMake compilation

[scrasmussen]

@islas what modules and commands are you using to configure this? I can get it to build and run with GNU but with Intel I'm getting the following errors during the configure step. I'm using the following command and get the error with -DENABLE_HYDRO=ON and without Hydro:

$ ./configure_new -x -p ifx/icx -- -DWRF_CORE=ARW -DWRF_NESTING=BASIC -DWRF_CASE=EM_REAL
...

-- Performing Check FSEEKO
CMake Warning (dev) at cmake/confcheck.cmake:30 (try_run):
  Unknown arguments:

    "-D_FILE_OFFSET_BITS=64"
    "-D_LARGEFILE_SOURCE=1"
    "-DFILE_TO_TEST="/glade/work/soren/src/wrf-hydro/prs/wrf/WRF-islas/CMakeLists.txt""
Call Stack (most recent call first):
  confcheck/CMakeLists.txt:51 (wrf_conf_check)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Error: The source directory "/glade/work/soren/src/wrf-hydro/prs/wrf/WRF-islas/tools/fseek_test.c" is a file, not a directory.
Specify --help for usage, or press the help button on the CMake GUI.
CMake Error at cmake/confcheck.cmake:30 (try_run):
  Failed to configure test project build system.
Call Stack (most recent call first):
  confcheck/CMakeLists.txt:51 (wrf_conf_check)


CMake Error: TRY_COMPILE attempt to remove -rf directory that does not contain CMakeTmp or CMakeScratch: "/glade/work/soren/src/wrf-hydro/prs/wrf/WRF-islas/_build/confcheck/confcheck/FSEEKO/"
-- Configuring incomplete, errors occurred!

Think it might be related to this commit? 5dd2c19

[islas]

@scrasmussen Yes, I tested these changes only on top of v4.6.1, so I think that subsequent commit broke things for ifx on Derecho.

The following two PRs are meant to address issues with ifx :
PR #2179
PR #2180

With those independent changes merged onto this, you should be able to test this fix for hydro.