Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating and cleaning up new udm microphysics for optimization #2177

Open
wants to merge 1 commit into
base: release-v4.7.0
Choose a base branch
from

Conversation

dudhia
Copy link
Collaborator

@dudhia dudhia commented Mar 7, 2025

TYPE: enhancement updates, optimization fix

KEYWORDS: microphysics constants and process update

SOURCE: Songyou Hong via internal

DESCRIPTION OF CHANGES:
Problem:
Previous code did not compile with intel -O3. Also changes to constants and process which are updates.

Solution:
Minor change allows optimized compile. New code performs more as expected and is cleaned up.

ISSUE: none

LIST OF MODIFIED FILES:
M dyn_em/solve_em.F
M phys/module_microphysics_driver.F
M phys/module_mp_udm.F
M phys/module_physics_init.F

TESTS CONDUCTED:

  1. compiles
  2. tested with 2d squall line case
  3. still need to test bit-for-bit

RELEASE NOTE: updates to new UDM mp scheme from developer.

@dudhia dudhia requested a review from a team as a code owner March 7, 2025 16:30
@dudhia
Copy link
Collaborator Author

dudhia commented Mar 7, 2025

In addition to checking what happened with regtest, need to do bit-for-bit test with mp_physics=27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant