Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in module_chem_utilities.F #2173

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from

Conversation

saneku
Copy link
Contributor

@saneku saneku commented Mar 1, 2025

Removed unnecessary factor in computation of dry air density in module_chem_utilities.F

TYPE: bug fix

KEYWORDS: WRF-Chem, dry air density

SOURCE: NOAA GSL, Alexander Ukhov (KAUST)

DESCRIPTION OF CHANGES:
Problem:
It was found that dry air density was miscalculated.

Solution:
Removed unnecessary factor. Simulations before and after did not show any significant difference, as expected.
result

LIST OF MODIFIED FILES:
M chem/module_chem_utilities.F

TESTS CONDUCTED:

  1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Fixed calculation of dry air density in module_chem_utilities.F. The bug had a very minor effect.

saneku and others added 29 commits October 5, 2024 14:30
…his is needed for volcanic eruption.

Corrected fractions for calculation of contribution of volcanic ash into chem(PM2.5) and chem(PM10) variables.
Added new emiss_opt_vol=3 for emissions of volcanic sulfate and water vapor.
…en its name matches with the current model time. otherwise file is not being read.
@saneku saneku requested a review from a team as a code owner March 1, 2025 11:21
@saneku saneku requested review from a team as code owners March 1, 2025 11:21
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants