-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix in module_chem_utilities.F #2173
Open
saneku
wants to merge
29
commits into
wrf-model:develop
Choose a base branch
from
saneku:bug_fix_in_chem_utils
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his is needed for volcanic eruption. Corrected fractions for calculation of contribution of volcanic ash into chem(PM2.5) and chem(PM10) variables. Added new emiss_opt_vol=3 for emissions of volcanic sulfate and water vapor.
…odule_wetdep_ls.F to module_vash_settling.F
…ls (ash and sulf).
…en its name matches with the current model time. otherwise file is not being read.
The regression test results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary factor in computation of dry air density in module_chem_utilities.F
TYPE: bug fix
KEYWORDS: WRF-Chem, dry air density
SOURCE: NOAA GSL, Alexander Ukhov (KAUST)
DESCRIPTION OF CHANGES:
Problem:
It was found that dry air density was miscalculated.
Solution:

Removed unnecessary factor. Simulations before and after did not show any significant difference, as expected.
LIST OF MODIFIED FILES:
M chem/module_chem_utilities.F
TESTS CONDUCTED:
RELEASE NOTE: Fixed calculation of dry air density in module_chem_utilities.F. The bug had a very minor effect.