Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving volcanic ash simulations #2168

Draft
wants to merge 30 commits into
base: develop
Choose a base branch
from

Conversation

saneku
Copy link
Contributor

@saneku saneku commented Feb 17, 2025

This PR incorporates corrections and improvements to the simulation of volcanic eruptions using WRF-Chem.

TYPE: new feature

KEYWORDS: volcanic eruption, emiss_opt_vol, ash, so2, water vapor, sulfate

SOURCE: Alexander Ukhov (KAUST)

DESCRIPTION OF CHANGES:
Problem:
bug in the gravitational settling of the ash. Large ash particles have a very high falling speed.

Solution:
Fix the bug and introduce the correction factor for large ash particles.

New additions:

  • Added calculation of optical properties of ash and sulfate aerosol
  • Added diagnostics for ash, so2 and sulfate. This can be used for mass balance check
  • Added emissions of water vapor and sulfate aerosols
  • Added new emiss_opt_vol=3, which implies the new emission preprocessing method (avoiding prep_chem_source.exe)
  • Many other small corrections and improvements

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)
M Registry/registry.chem
A chem/Makefile_org
M chem/aerosol_driver.F
M chem/chem_driver.F
M chem/chemics_init.F
M chem/dry_dep_driver.F
M chem/emissions_driver.F
M chem/mechanism_driver.F
M chem/module_chem_utilities.F
M chem/module_ctrans_grell.F
M chem/module_optical_averaging.F
M chem/module_vash_settling.F
A chem/module_volc_chem.F
M chem/module_wetdep_ls.F
M chem/optical_driver.F
M share/mediation_integrate.F

TESTS CONDUCTED:

  1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Added new capabilities to simulate volcanic eruptions. A full description of additions and changes is planned in the upcoming GMD publication.

saneku and others added 25 commits October 5, 2024 14:30
…his is needed for volcanic eruption.

Corrected fractions for calculation of contribution of volcanic ash into chem(PM2.5) and chem(PM10) variables.
Added new emiss_opt_vol=3 for emissions of volcanic sulfate and water vapor.
…en its name matches with the current model time. otherwise file is not being read.
@weiwangncar
Copy link
Collaborator

@saneku The regression tests failed with WRF-Chem compilation. Check your inbox and spam folder to see if you received any email and attachment from [email protected]. Or you can check the attached file.
output_1.txt

@saneku saneku marked this pull request as ready for review February 20, 2025 09:22
@saneku saneku requested a review from a team as a code owner February 20, 2025 09:22
@saneku saneku requested review from a team as code owners February 20, 2025 09:22
@weiwangncar
Copy link
Collaborator

weiwangncar commented Feb 20, 2025

@saneku Thanks for trying, but the WRF-Chem tests are still failing... Can you compile WRF-Chem successfully at your local computer? The regression tests use a gfortran compiler.

@saneku saneku marked this pull request as draft February 21, 2025 09:04
@saneku
Copy link
Contributor Author

saneku commented Feb 24, 2025

@weiwangncar please provide compile log file.

@weiwangncar
Copy link
Collaborator

@saneku Here it is. Still just the chemistry that didn't compile.
output_1.txt

@weiwangncar
Copy link
Collaborator

Nicely done! The results from the regression tests are below:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar
Copy link
Collaborator

@jordanschnell I'm again asking for your help reviewing this PR, when you have some time. Thanks!

@jordanschnell
Copy link
Contributor

@weiwangncar - I've been working with Sasha to fix the compilation issues, etc.

@saneku - could you package the additional diagnostics? (e.g., wd_*, *_drydep, settl, and *_loss)

Otherwise it's looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants